Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed importer audit date validation issue #14908

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Fixed importer audit date validation issue #14908

merged 3 commits into from
Jun 19, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jun 19, 2024

We were using an invalid field name for one of the field maps in the importer. I also pulled the date time validation from last_audit_date, since we use an accessor and a mutator nowadays, so we'll always get it as a date time or a null.

@what-the-diff What The Diff
Copy link

what-the-diff bot commented Jun 19, 2024

PR Summary

  • Correction in Asset Data Import
    The original code in the AssetImporter.php was incorrectly looking at the next_audit_date for the value of asset_eol_date. This has now been corrected to pull the asset_eol_date from its correct column in the CSV file.

  • Changes to Asset Audit Date Validation
    The validation rule for last_audit_date in Asset.php now allows for more flexible formats by removing the specific date and time structure. This change will make the system more robust, accommodating varying date inputs.

@snipe snipe merged commit 98662c2 into develop Jun 19, 2024
4 of 8 checks passed
@snipe snipe deleted the fixes/importer_audit_date branch June 19, 2024 10:12
@snipe snipe changed the title Fixes/importer audit date Fixed importer audit date validation issue Jun 19, 2024
@snipe snipe mentioned this pull request Aug 2, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backend importer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@snipe